Repository navigation
conformance: add the traversal, unsafe and local IJ groups - #1286
Draft
justinhwang wants to merge 1 commit into
Draft
justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 5, 2026 18:50
2327a3c to
41c518c
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 5, 2026 19:32
41c518c to
9d97b9c
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 5, 2026 22:38
9d97b9c to
ed4a822
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 6, 2026 16:54
ed4a822 to
0f7fa5d
Compare
isaacbrodsky
force-pushed
the
conformance-2-traversal
branch
from
November 8, 2026 16:33
0f7fa5d to
2559ff4
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
2 times, most recently
from
November 9, 2026 15:39
5349e12 to
a8a7e2f
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 19, 2026 17:51
a8a7e2f to
2e1edba
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 19, 2026 18:09
2e1edba to
5c008fd
Compare
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 19, 2026 18:11
5c008fd to
d504402
Compare
Adds the record files and runners for grid traversal: gridRing, gridDisk and gridDiskDistances for k 1 to 3, gridDistance, gridPathCells and areNeighborCells against a target drawn from the 3-disk; gridDiskUnsafe, gridDiskDistancesUnsafe and gridRingUnsafe outcomes for every cell within one step of a pentagon's 4-disk; and cellToLocalIj with localIjToCell for near and far targets. The curated traversal and local IJ files hold the fixtures of the existing tests and the CLI examples. The files are the generator's output and are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justinhwang
force-pushed
the
conformance-2-traversal
branch
from
November 19, 2026 18:40
d504402 to
4a6fae3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the record files and runners for grid traversal.
Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is
dev-docs/conformance.md.Functions covered
gridRing,gridDisk,gridDiskDistances,gridDiskDistancesSafefor k 1 to 3;gridDistance,gridPathCellsandareNeighborCellsagainst a target drawn from the 3-disk.gridDiskUnsafe,gridDiskDistancesUnsafe,gridDisksUnsafe(one origin),gridRingUnsafe: the outcome (result orE_PENTAGON) for every cell within one step of a pentagon's 4-disk, checked against the safe functions.cellToLocalIjandlocalIjToCellfor near and far targets, including the error cases.Files
traversal/cells.jsonltraversal/curated.jsonlunsafe/cells.jsonllocalij/pairs.jsonllocalij/curated.jsonlThe curated files hold the fixtures of the existing tests and the CLI examples. Runners:
testConformanceTraversal,testConformanceUnsafe,testConformanceLocalIj.The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.
🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬