Skip to content

conformance: add the traversal, unsafe and local IJ groups - #1286

Draft
justinhwang wants to merge 1 commit into
conformance-1-inspectionfrom
conformance-2-traversal
Draft

justinhwang wants to merge 1 commit into
conformance-1-inspectionfrom
conformance-2-traversal

Conversation

@justinhwang

@justinhwang justinhwang commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the record files and runners for grid traversal.

Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is dev-docs/conformance.md.

Functions covered

  • gridRing, gridDisk, gridDiskDistances, gridDiskDistancesSafe for k 1 to 3; gridDistance, gridPathCells and areNeighborCells against a target drawn from the 3-disk.
  • gridDiskUnsafe, gridDiskDistancesUnsafe, gridDisksUnsafe (one origin), gridRingUnsafe: the outcome (result or E_PENTAGON) for every cell within one step of a pentagon's 4-disk, checked against the safe functions.
  • cellToLocalIj and localIjToCell for near and far targets, including the error cases.

Files

File Rows
traversal/cells.jsonl 542
traversal/curated.jsonl 14
unsafe/cells.jsonl 9,527
localij/pairs.jsonl 1,084
localij/curated.jsonl 12

The curated files hold the fixtures of the existing tests and the CLI examples. Runners: testConformanceTraversal, testConformanceUnsafe, testConformanceLocalIj.

The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.

🤖 Generated with Claude Code


Stack created with GitHub Stacks CLI • Give Feedback 💬

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coveralls

coveralls commented Nov 5, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 99.687% — conformance-2-traversal into conformance-1-inspection. No base build found for conformance-1-inspection.

@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from 41c518c to 9d97b9c Compare November 5, 2026 19:32
@justinhwang
justinhwang removed this pull request from stack #1291 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from 9d97b9c to ed4a822 Compare November 5, 2026 22:38
@justinhwang
justinhwang added this pull request to stack #1295 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from ed4a822 to 0f7fa5d Compare November 6, 2026 16:54
@isaacbrodsky
isaacbrodsky force-pushed the conformance-2-traversal branch from 0f7fa5d to 2559ff4 Compare November 8, 2026 16:33
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch 2 times, most recently from 5349e12 to a8a7e2f Compare November 9, 2026 15:39
@justinhwang justinhwang changed the title Add the traversal, unsafe and local IJ conformance groups conformance: add the traversal, unsafe and local IJ groups Nov 12, 2026
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from a8a7e2f to 2e1edba Compare November 19, 2026 17:51
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from 2e1edba to 5c008fd Compare November 19, 2026 18:09
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from 5c008fd to d504402 Compare November 19, 2026 18:11
Adds the record files and runners for grid traversal: gridRing, gridDisk
and gridDiskDistances for k 1 to 3, gridDistance, gridPathCells and
areNeighborCells against a target drawn from the 3-disk; gridDiskUnsafe,
gridDiskDistancesUnsafe and gridRingUnsafe outcomes for every cell within
one step of a pentagon's 4-disk; and cellToLocalIj with localIjToCell for
near and far targets. The curated traversal and local IJ files hold the
fixtures of the existing tests and the CLI examples.

The files are the generator's output and are byte-identical to the ones
generated in h3-go from v4.5.0 at seed 20260929.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@justinhwang
justinhwang force-pushed the conformance-2-traversal branch from d504402 to 4a6fae3 Compare November 19, 2026 18:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants